{ "url": "https://api.github.com/repos/NixOS/nixpkgs/pulls/345583", "id": 2099869862, "node_id": "PR_kwDOAEVQ_M59KXim", "html_url": "https://github.com/NixOS/nixpkgs/pull/345583", "diff_url": "https://github.com/NixOS/nixpkgs/pull/345583.diff", "patch_url": "https://github.com/NixOS/nixpkgs/pull/345583.patch", "issue_url": "https://api.github.com/repos/NixOS/nixpkgs/issues/345583", "number": 345583, "state": "closed", "locked": false, "title": "wireshark: 4.2.6 -> 4.2.7", "user": { "login": "LeSuisse", "id": 737767, "node_id": "MDQ6VXNlcjczNzc2Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/737767?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LeSuisse", "html_url": "https://github.com/LeSuisse", "followers_url": "https://api.github.com/users/LeSuisse/followers", "following_url": "https://api.github.com/users/LeSuisse/following{/other_user}", "gists_url": "https://api.github.com/users/LeSuisse/gists{/gist_id}", "starred_url": "https://api.github.com/users/LeSuisse/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LeSuisse/subscriptions", "organizations_url": "https://api.github.com/users/LeSuisse/orgs", "repos_url": "https://api.github.com/users/LeSuisse/repos", "events_url": "https://api.github.com/users/LeSuisse/events{/privacy}", "received_events_url": "https://api.github.com/users/LeSuisse/received_events", "type": "User", "site_admin": false }, "body": "## Description of changes\r\n\r\nFixes CVE-2024-8250.\r\nhttps://www.wireshark.org/security/wnpa-sec-2024-11.html\r\n\r\nChanges:\r\nhttps://www.wireshark.org/docs/relnotes/wireshark-4.2.7.html\r\n\r\n\r\n## Things done\r\n\r\n\r\n\r\n- Built on platform(s)\r\n - [x] x86_64-linux\r\n - [ ] aarch64-linux\r\n - [ ] x86_64-darwin\r\n - [ ] aarch64-darwin\r\n- For non-Linux: Is sandboxing enabled in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html))\r\n - [ ] `sandbox = relaxed`\r\n - [ ] `sandbox = true`\r\n- [ ] Tested, as applicable:\r\n - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n - and/or [package tests](https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests)\r\n - or, for functions and \"core\" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test)\r\n - made sure NixOS tests are [linked](https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#linking-nixos-module-tests-to-a-package) to the relevant packages\r\n- [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run \"nixpkgs-review rev HEAD\"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage)\r\n- [x] Tested basic functionality of all binary files (usually in `./result/bin/`)\r\n- [24.11 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2411.section.md) (or backporting [23.11](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) and [24.05](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2405.section.md) Release notes)\r\n - [ ] (Package updates) Added a release notes entry if the change is major or breaking\r\n - [ ] (Module updates) Added a release notes entry if the change is significant\r\n - [ ] (Module addition) Added a release notes entry if adding a new NixOS module\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).\r\n\r\n\r\n\r\nResult of `nixpkgs-review` run on x86_64-linux [1](https://github.com/Mic92/nixpkgs-review)\r\n
\r\n 4 packages marked as broken and skipped:\r\n \r\n
\r\n
\r\n 24 packages built:\r\n \r\n
\r\n\r\n---\r\n\r\nAdd a :+1: [reaction] to [pull requests you find important].\r\n\r\n[reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/\r\n[pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc\r\n", "created_at": "2024-09-30T19:26:00Z", "updated_at": "2024-10-01T08:26:57Z", "closed_at": "2024-10-01T06:56:48Z", "merged_at": "2024-10-01T06:56:48Z", "merge_commit_sha": "2c5fac3edf2d00d948253e392ec1604b29b38f14", "assignee": null, "assignees": [ ], "requested_reviewers": [ { "login": "fpletz", "id": 114159, "node_id": "MDQ6VXNlcjExNDE1OQ==", "avatar_url": "https://avatars.githubusercontent.com/u/114159?v=4", "gravatar_id": "", "url": "https://api.github.com/users/fpletz", "html_url": "https://github.com/fpletz", "followers_url": "https://api.github.com/users/fpletz/followers", "following_url": "https://api.github.com/users/fpletz/following{/other_user}", "gists_url": "https://api.github.com/users/fpletz/gists{/gist_id}", "starred_url": "https://api.github.com/users/fpletz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/fpletz/subscriptions", "organizations_url": "https://api.github.com/users/fpletz/orgs", "repos_url": "https://api.github.com/users/fpletz/repos", "events_url": "https://api.github.com/users/fpletz/events{/privacy}", "received_events_url": "https://api.github.com/users/fpletz/received_events", "type": "User", "site_admin": false } ], "requested_teams": [ ], "labels": [ { "id": 126506420, "node_id": "MDU6TGFiZWwxMjY1MDY0MjA=", "url": "https://api.github.com/repos/NixOS/nixpkgs/labels/1.severity:%20security", "name": "1.severity: security", "color": "e11d21", "default": false, "description": null }, { "id": 731734101, "node_id": "MDU6TGFiZWw3MzE3MzQxMDE=", "url": "https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%2011-100", "name": "10.rebuild-linux: 11-100", "color": "fbca04", "default": false, "description": null }, { "id": 731735423, "node_id": "MDU6TGFiZWw3MzE3MzU0MjM=", "url": "https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%2011-100", "name": "10.rebuild-darwin: 11-100", "color": "fbca04", "default": false, "description": null }, { "id": 6984924132, "node_id": "LA_kwDOAEVQ_M8AAAABoFV75A", "url": "https://api.github.com/repos/NixOS/nixpkgs/labels/backport%20release-24.05", "name": "backport release-24.05", "color": "0fafaa", "default": false, "description": "Backport PR automatically" } ], "milestone": null, "draft": false, "commits_url": "https://api.github.com/repos/NixOS/nixpkgs/pulls/345583/commits", "review_comments_url": "https://api.github.com/repos/NixOS/nixpkgs/pulls/345583/comments", "review_comment_url": "https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}", "comments_url": "https://api.github.com/repos/NixOS/nixpkgs/issues/345583/comments", "statuses_url": "https://api.github.com/repos/NixOS/nixpkgs/statuses/64a0ed1ab2dbbf66d7674d5d5787537341d961b0", "head": { "label": "LeSuisse:wireshark-4.2.7", "ref": "wireshark-4.2.7", "sha": "64a0ed1ab2dbbf66d7674d5d5787537341d961b0", "user": { "login": "LeSuisse", "id": 737767, "node_id": "MDQ6VXNlcjczNzc2Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/737767?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LeSuisse", "html_url": "https://github.com/LeSuisse", "followers_url": "https://api.github.com/users/LeSuisse/followers", "following_url": "https://api.github.com/users/LeSuisse/following{/other_user}", "gists_url": "https://api.github.com/users/LeSuisse/gists{/gist_id}", "starred_url": "https://api.github.com/users/LeSuisse/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LeSuisse/subscriptions", "organizations_url": "https://api.github.com/users/LeSuisse/orgs", "repos_url": "https://api.github.com/users/LeSuisse/repos", "events_url": "https://api.github.com/users/LeSuisse/events{/privacy}", "received_events_url": "https://api.github.com/users/LeSuisse/received_events", "type": "User", "site_admin": false }, "repo": { "id": 330208195, "node_id": "MDEwOlJlcG9zaXRvcnkzMzAyMDgxOTU=", "name": "nixpkgs", "full_name": "LeSuisse/nixpkgs", "private": false, "owner": { "login": "LeSuisse", "id": 737767, "node_id": "MDQ6VXNlcjczNzc2Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/737767?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LeSuisse", "html_url": "https://github.com/LeSuisse", "followers_url": "https://api.github.com/users/LeSuisse/followers", "following_url": "https://api.github.com/users/LeSuisse/following{/other_user}", "gists_url": "https://api.github.com/users/LeSuisse/gists{/gist_id}", "starred_url": "https://api.github.com/users/LeSuisse/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LeSuisse/subscriptions", "organizations_url": "https://api.github.com/users/LeSuisse/orgs", "repos_url": "https://api.github.com/users/LeSuisse/repos", "events_url": "https://api.github.com/users/LeSuisse/events{/privacy}", "received_events_url": "https://api.github.com/users/LeSuisse/received_events", "type": "User", "site_admin": false }, "html_url": "https://github.com/LeSuisse/nixpkgs", "description": "Nix Packages collection", "fork": true, "url": "https://api.github.com/repos/LeSuisse/nixpkgs", "forks_url": "https://api.github.com/repos/LeSuisse/nixpkgs/forks", "keys_url": "https://api.github.com/repos/LeSuisse/nixpkgs/keys{/key_id}", "collaborators_url": "https://api.github.com/repos/LeSuisse/nixpkgs/collaborators{/collaborator}", "teams_url": "https://api.github.com/repos/LeSuisse/nixpkgs/teams", "hooks_url": "https://api.github.com/repos/LeSuisse/nixpkgs/hooks", "issue_events_url": "https://api.github.com/repos/LeSuisse/nixpkgs/issues/events{/number}", "events_url": "https://api.github.com/repos/LeSuisse/nixpkgs/events", "assignees_url": "https://api.github.com/repos/LeSuisse/nixpkgs/assignees{/user}", "branches_url": "https://api.github.com/repos/LeSuisse/nixpkgs/branches{/branch}", "tags_url": "https://api.github.com/repos/LeSuisse/nixpkgs/tags", "blobs_url": "https://api.github.com/repos/LeSuisse/nixpkgs/git/blobs{/sha}", "git_tags_url": "https://api.github.com/repos/LeSuisse/nixpkgs/git/tags{/sha}", "git_refs_url": "https://api.github.com/repos/LeSuisse/nixpkgs/git/refs{/sha}", "trees_url": "https://api.github.com/repos/LeSuisse/nixpkgs/git/trees{/sha}", "statuses_url": "https://api.github.com/repos/LeSuisse/nixpkgs/statuses/{sha}", "languages_url": "https://api.github.com/repos/LeSuisse/nixpkgs/languages", "stargazers_url": "https://api.github.com/repos/LeSuisse/nixpkgs/stargazers", "contributors_url": "https://api.github.com/repos/LeSuisse/nixpkgs/contributors", "subscribers_url": "https://api.github.com/repos/LeSuisse/nixpkgs/subscribers", "subscription_url": "https://api.github.com/repos/LeSuisse/nixpkgs/subscription", "commits_url": "https://api.github.com/repos/LeSuisse/nixpkgs/commits{/sha}", "git_commits_url": "https://api.github.com/repos/LeSuisse/nixpkgs/git/commits{/sha}", "comments_url": "https://api.github.com/repos/LeSuisse/nixpkgs/comments{/number}", "issue_comment_url": "https://api.github.com/repos/LeSuisse/nixpkgs/issues/comments{/number}", "contents_url": "https://api.github.com/repos/LeSuisse/nixpkgs/contents/{+path}", "compare_url": "https://api.github.com/repos/LeSuisse/nixpkgs/compare/{base}...{head}", "merges_url": "https://api.github.com/repos/LeSuisse/nixpkgs/merges", "archive_url": "https://api.github.com/repos/LeSuisse/nixpkgs/{archive_format}{/ref}", "downloads_url": "https://api.github.com/repos/LeSuisse/nixpkgs/downloads", "issues_url": "https://api.github.com/repos/LeSuisse/nixpkgs/issues{/number}", "pulls_url": "https://api.github.com/repos/LeSuisse/nixpkgs/pulls{/number}", "milestones_url": "https://api.github.com/repos/LeSuisse/nixpkgs/milestones{/number}", "notifications_url": "https://api.github.com/repos/LeSuisse/nixpkgs/notifications{?since,all,participating}", "labels_url": "https://api.github.com/repos/LeSuisse/nixpkgs/labels{/name}", "releases_url": "https://api.github.com/repos/LeSuisse/nixpkgs/releases{/id}", "deployments_url": "https://api.github.com/repos/LeSuisse/nixpkgs/deployments", "created_at": "2021-01-16T16:40:54Z", "updated_at": "2024-05-30T20:02:25Z", "pushed_at": "2024-10-03T13:24:28Z", "git_url": "git://github.com/LeSuisse/nixpkgs.git", "ssh_url": "git@github.com:LeSuisse/nixpkgs.git", "clone_url": "https://github.com/LeSuisse/nixpkgs.git", "svn_url": "https://github.com/LeSuisse/nixpkgs", "homepage": "", "size": 4437697, "stargazers_count": 1, "watchers_count": 1, "language": "Nix", "has_issues": false, "has_projects": true, "has_downloads": true, "has_wiki": false, "has_pages": false, "has_discussions": false, "forks_count": 0, "mirror_url": null, "archived": false, "disabled": false, "open_issues_count": 0, "license": { "key": "mit", "name": "MIT License", "spdx_id": "MIT", "url": "https://api.github.com/licenses/mit", "node_id": "MDc6TGljZW5zZTEz" }, "allow_forking": true, "is_template": false, "web_commit_signoff_required": false, "topics": [ ], "visibility": "public", "forks": 0, "open_issues": 0, "watchers": 1, "default_branch": "master" } }, "base": { "label": "NixOS:master", "ref": "master", "sha": "c1e68f011844844605548984e3c8cd1a9379d78f", "user": { "login": "NixOS", "id": 487568, "node_id": "MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==", "avatar_url": "https://avatars.githubusercontent.com/u/487568?v=4", "gravatar_id": "", "url": "https://api.github.com/users/NixOS", "html_url": "https://github.com/NixOS", "followers_url": "https://api.github.com/users/NixOS/followers", "following_url": "https://api.github.com/users/NixOS/following{/other_user}", "gists_url": "https://api.github.com/users/NixOS/gists{/gist_id}", "starred_url": "https://api.github.com/users/NixOS/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/NixOS/subscriptions", "organizations_url": "https://api.github.com/users/NixOS/orgs", "repos_url": "https://api.github.com/users/NixOS/repos", "events_url": "https://api.github.com/users/NixOS/events{/privacy}", "received_events_url": "https://api.github.com/users/NixOS/received_events", "type": "Organization", "site_admin": false }, "repo": { "id": 4542716, "node_id": "MDEwOlJlcG9zaXRvcnk0NTQyNzE2", "name": "nixpkgs", "full_name": "NixOS/nixpkgs", "private": false, "owner": { "login": "NixOS", "id": 487568, "node_id": "MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==", "avatar_url": "https://avatars.githubusercontent.com/u/487568?v=4", "gravatar_id": "", "url": "https://api.github.com/users/NixOS", "html_url": "https://github.com/NixOS", "followers_url": "https://api.github.com/users/NixOS/followers", "following_url": "https://api.github.com/users/NixOS/following{/other_user}", "gists_url": "https://api.github.com/users/NixOS/gists{/gist_id}", "starred_url": "https://api.github.com/users/NixOS/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/NixOS/subscriptions", "organizations_url": "https://api.github.com/users/NixOS/orgs", "repos_url": "https://api.github.com/users/NixOS/repos", "events_url": "https://api.github.com/users/NixOS/events{/privacy}", "received_events_url": "https://api.github.com/users/NixOS/received_events", "type": "Organization", "site_admin": false }, "html_url": "https://github.com/NixOS/nixpkgs", "description": "Nix Packages collection & NixOS", "fork": false, "url": "https://api.github.com/repos/NixOS/nixpkgs", "forks_url": "https://api.github.com/repos/NixOS/nixpkgs/forks", "keys_url": "https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}", "collaborators_url": "https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}", "teams_url": "https://api.github.com/repos/NixOS/nixpkgs/teams", "hooks_url": "https://api.github.com/repos/NixOS/nixpkgs/hooks", "issue_events_url": "https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}", "events_url": "https://api.github.com/repos/NixOS/nixpkgs/events", "assignees_url": "https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}", "branches_url": "https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}", "tags_url": "https://api.github.com/repos/NixOS/nixpkgs/tags", "blobs_url": "https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}", "git_tags_url": "https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}", "git_refs_url": "https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}", "trees_url": "https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}", "statuses_url": "https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}", "languages_url": "https://api.github.com/repos/NixOS/nixpkgs/languages", "stargazers_url": "https://api.github.com/repos/NixOS/nixpkgs/stargazers", "contributors_url": "https://api.github.com/repos/NixOS/nixpkgs/contributors", "subscribers_url": "https://api.github.com/repos/NixOS/nixpkgs/subscribers", "subscription_url": "https://api.github.com/repos/NixOS/nixpkgs/subscription", "commits_url": "https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}", "git_commits_url": "https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}", "comments_url": "https://api.github.com/repos/NixOS/nixpkgs/comments{/number}", "issue_comment_url": "https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}", "contents_url": "https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}", "compare_url": "https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}", "merges_url": "https://api.github.com/repos/NixOS/nixpkgs/merges", "archive_url": "https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}", "downloads_url": "https://api.github.com/repos/NixOS/nixpkgs/downloads", "issues_url": "https://api.github.com/repos/NixOS/nixpkgs/issues{/number}", "pulls_url": "https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}", "milestones_url": "https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}", "notifications_url": "https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}", "labels_url": "https://api.github.com/repos/NixOS/nixpkgs/labels{/name}", "releases_url": "https://api.github.com/repos/NixOS/nixpkgs/releases{/id}", "deployments_url": "https://api.github.com/repos/NixOS/nixpkgs/deployments", "created_at": "2012-06-04T02:49:46Z", "updated_at": "2024-10-05T22:47:49Z", "pushed_at": "2024-10-05T22:34:39Z", "git_url": "git://github.com/NixOS/nixpkgs.git", "ssh_url": "git@github.com:NixOS/nixpkgs.git", "clone_url": "https://github.com/NixOS/nixpkgs.git", "svn_url": "https://github.com/NixOS/nixpkgs", "homepage": "", "size": 4520403, "stargazers_count": 17638, "watchers_count": 17638, "language": "Nix", "has_issues": true, "has_projects": true, "has_downloads": true, "has_wiki": false, "has_pages": false, "has_discussions": false, "forks_count": 13796, "mirror_url": null, "archived": false, "disabled": false, "open_issues_count": 15342, "license": { "key": "mit", "name": "MIT License", "spdx_id": "MIT", "url": "https://api.github.com/licenses/mit", "node_id": "MDc6TGljZW5zZTEz" }, "allow_forking": true, "is_template": false, "web_commit_signoff_required": false, "topics": [ "hacktoberfest", "linux", "nix", "nixos", "nixpkgs" ], "visibility": "public", "forks": 13796, "open_issues": 15342, "watchers": 17638, "default_branch": "master" } }, "_links": { "self": { "href": "https://api.github.com/repos/NixOS/nixpkgs/pulls/345583" }, "html": { "href": "https://github.com/NixOS/nixpkgs/pull/345583" }, "issue": { "href": "https://api.github.com/repos/NixOS/nixpkgs/issues/345583" }, "comments": { "href": "https://api.github.com/repos/NixOS/nixpkgs/issues/345583/comments" }, "review_comments": { "href": "https://api.github.com/repos/NixOS/nixpkgs/pulls/345583/comments" }, "review_comment": { "href": "https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}" }, "commits": { "href": "https://api.github.com/repos/NixOS/nixpkgs/pulls/345583/commits" }, "statuses": { "href": "https://api.github.com/repos/NixOS/nixpkgs/statuses/64a0ed1ab2dbbf66d7674d5d5787537341d961b0" } }, "author_association": "CONTRIBUTOR", "auto_merge": null, "active_lock_reason": null, "merged": true, "mergeable": null, "rebaseable": null, "mergeable_state": "unknown", "merged_by": { "login": "bjornfor", "id": 133602, "node_id": "MDQ6VXNlcjEzMzYwMg==", "avatar_url": "https://avatars.githubusercontent.com/u/133602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bjornfor", "html_url": "https://github.com/bjornfor", "followers_url": "https://api.github.com/users/bjornfor/followers", "following_url": "https://api.github.com/users/bjornfor/following{/other_user}", "gists_url": "https://api.github.com/users/bjornfor/gists{/gist_id}", "starred_url": "https://api.github.com/users/bjornfor/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bjornfor/subscriptions", "organizations_url": "https://api.github.com/users/bjornfor/orgs", "repos_url": "https://api.github.com/users/bjornfor/repos", "events_url": "https://api.github.com/users/bjornfor/events{/privacy}", "received_events_url": "https://api.github.com/users/bjornfor/received_events", "type": "User", "site_admin": false }, "comments": 2, "review_comments": 0, "maintainer_can_modify": false, "commits": 1, "additions": 2, "deletions": 2, "changed_files": 1 }