From 3588fa670e3cd70b5f8fc55f0336476cb44fe6c4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Torjus=20H=C3=A5kestad?= <torjus@usit.uio.no>
Date: Wed, 28 May 2025 21:05:28 +0200
Subject: [PATCH] Fix shellcheck warnings in build-flakes

---
 services/nix-cache/build-flakes.sh | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/services/nix-cache/build-flakes.sh b/services/nix-cache/build-flakes.sh
index d3de19f..99aacde 100644
--- a/services/nix-cache/build-flakes.sh
+++ b/services/nix-cache/build-flakes.sh
@@ -7,8 +7,7 @@ git pull
 echo "Starting nixos-servers builds"
 for host in $(nix flake show --json| jq -r '.nixosConfigurations | keys[]'); do
   echo "Building $host"
-  nixos-rebuild --verbose -L --flake ".#$host" build
-  if [ $? -ne 0 ]; then
+  if ! nixos-rebuild --verbose -L --flake ".#$host" build; then
     echo "Build failed for $host"
     cat <<EOF | curl --data-binary @- "https://pushgw.home.2rjus.net/metrics/job/$JOB_NAME"
 # TYPE build_flakes_error gauge
@@ -30,8 +29,7 @@ echo "Building gunter"
 cd /root/nixos
 git pull
 host="gunter"
-nixos-rebuild --verbose -L --flake ".#gunter" build
-if [ $? -ne 0 ]; then
+if ! nixos-rebuild --verbose -L --flake ".#gunter" build; then
     echo "Build failed for $host"
     cat <<EOF | curl --data-binary @- "https://pushgw.home.2rjus.net/metrics/job/$JOB_NAME"
 # TYPE build_flakes_error gauge